Skip to content

Fix document in control-plane/architecture-overview: "api" > "server"#1224

Merged
pipecd-bot merged 1 commit intopipe-cd:masterfrom
ShotaKitazawa:master
Dec 10, 2020
Merged

Fix document in control-plane/architecture-overview: "api" > "server"#1224
pipecd-bot merged 1 commit intopipe-cd:masterfrom
ShotaKitazawa:master

Conversation

@ShotaKitazawa
Copy link
Contributor

@ShotaKitazawa ShotaKitazawa commented Dec 9, 2020

What this PR does / why we need it:

fix document:
In architecture overview of control-plane, written as cache used by api. I think cache use by server is correct after PipeCD v0.8.0.

If I am wrong, please close this PR.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested a review from nakabonne December 9, 2020 15:51
@pipecd-bot pipecd-bot requested a review from nghialv December 9, 2020 15:51
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 9, 2020

CLA

Welcome @ShotaKitazawa!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@ShotaKitazawa
Copy link
Contributor Author

ShotaKitazawa commented Dec 9, 2020

/cla sign

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 9, 2020

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@nghialv nghialv changed the title fix document in control-plane/architecture-overview: "api" > "server" Fix document in control-plane/architecture-overview: "api" > "server" Dec 10, 2020
@nghialv
Copy link
Member

nghialv commented Dec 10, 2020

@ShotaKitazawa Thank you for your pull request.
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv
Copy link
Member

nghialv commented Dec 10, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Dec 10, 2020

COVERAGE

Code coverage for golang is 33.96%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 856feaf into pipe-cd:master Dec 10, 2020
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nakabonne nakabonne Awaiting requested review from nakabonne

@nghialv nghialv Awaiting requested review from nghialv

Assignees

No one assigned

Labels

approved area/docs area/site release-note-none size/XS trigger/needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShotaKitazawa @pipecd-bot @nghialv